Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3626)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 941543002: Mac: Speculative fix for tracking area crashes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bgv
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/cocoa/base_view.mm » ('j') | ui/base/cocoa/base_view.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 1afc9064b7faf1a63575a9dad972909599b4eb54..74b527fc400e1eebe06da60f837692ac78c89caa 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -395,6 +395,16 @@ using content::WebContents;
NSWindowCollectionBehaviorFullScreenAuxiliary;
[window setCollectionBehavior:collectionBehavior];
+ // NSTrackingInVisibleRect doesn't work correctly with Lion's window
+ // resizing, http://crbug.com/176725 /
+ // http://openradar.appspot.com/radar?id=2773401 .
+ // Setting this property will send mouseMoved events to the window's first
+ // responder, so it will avoid the problem as long as the
+ // RenderWidgetHostViewCocoa is first responder.
+ // The bug will still be there if the omnibox has focus (Safari suffers
+ // from the same problem).
+ [window setAcceptsMouseMovedEvents:YES];
+
[self layoutSubviews];
// For a popup window, |desiredContentRect| contains the desired height of
« no previous file with comments | « no previous file | ui/base/cocoa/base_view.mm » ('j') | ui/base/cocoa/base_view.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698