ui/gfx/render_text_harfbuzz.cc - Issue 941523002: Rename: background_is_transparent -> subpixel_rendering_enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 941523002: Rename: background_is_transparent -> subpixel_rendering_enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: win fix Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text_harfbuzz.cc

diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc

index 6d1e2bb421e4e5f9fd4d9d6be4c80d5198aaa052..67b02bf7d002a02509da144606b52f3622841171 100644

--- a/ui/gfx/render_text_harfbuzz.cc

+++ b/ui/gfx/render_text_harfbuzz.cc

@@ -1018,7 +1018,7 @@ void RenderTextHarfBuzz::DrawVisualTextInternal(

renderer->SetTypeface(run.skia_face.get());

renderer->SetTextSize(SkIntToScalar(run.font_size));

renderer->SetFontRenderParams(run.render_params,

- background_is_transparent());

+ subpixel_rendering_suppressed());

Range glyphs_range = run.CharRangeToGlyphRange(segment.char_range);

scoped_ptr<SkPoint[]> positions(new SkPoint[glyphs_range.length()]);

SkScalar offset_x = preceding_segment_widths -

@@ -1308,7 +1308,7 @@ bool RenderTextHarfBuzz::ShapeRunWithFont(const base::string16& text,

hb_font_t* harfbuzz_font = CreateHarfBuzzFont(

run->skia_face.get(), SkIntToScalar(run->font_size), run->render_params,

- background_is_transparent());

+ subpixel_rendering_suppressed());

// TODO(vadimt): Remove ScopedTracker below once crbug.com/431326 is fixed.

tracked_objects::ScopedTracker tracking_profile1(

« no previous file with comments | « ui/gfx/render_text.cc ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »