Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: ui/gfx/render_text.h

Issue 941523002: Rename: background_is_transparent -> subpixel_rendering_enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/harfbuzz_font_skia.cc ('k') | ui/gfx/render_text.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index 2be04acd352641e4333468d5492cf8ef8784da4c..4d629a00a0479cefddad8a86a0d5b453e9941288 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -52,7 +52,7 @@ class GFX_EXPORT SkiaTextRenderer {
void SetDrawLooper(SkDrawLooper* draw_looper);
void SetFontRenderParams(const FontRenderParams& params,
- bool background_is_transparent);
+ bool subpixel_rendering_suppressed);
void SetTypeface(SkTypeface* typeface);
void SetTextSize(SkScalar size);
void SetFontFamilyWithStyle(const std::string& family, int font_style);
@@ -181,7 +181,7 @@ skia::RefPtr<SkTypeface> CreateSkiaTypeface(const std::string& family,
// Applies the given FontRenderParams to a Skia |paint|.
void ApplyRenderParams(const FontRenderParams& params,
- bool background_is_transparent,
+ bool subpixel_rendering_suppressed,
SkPaint* paint);
} // namespace internal
@@ -273,9 +273,11 @@ class GFX_EXPORT RenderText {
const Rect& display_rect() const { return display_rect_; }
void SetDisplayRect(const Rect& r);
- bool background_is_transparent() const { return background_is_transparent_; }
- void set_background_is_transparent(bool transparent) {
- background_is_transparent_ = transparent;
+ bool subpixel_rendering_suppressed() const {
+ return subpixel_rendering_suppressed_;
+ }
+ void set_subpixel_rendering_suppressed(bool suppressed) {
+ subpixel_rendering_suppressed_ = suppressed;
}
const SelectionModel& selection_model() const { return selection_model_; }
@@ -732,8 +734,9 @@ class GFX_EXPORT RenderText {
// |display_rect_| as the width cap.
bool multiline_;
- // Is the background transparent (either partially or fully)?
- bool background_is_transparent_;
+ // Set to true to suppress subpixel rendering due to non-font reasons (eg.
+ // if the background is transparent). The default value is false.
+ bool subpixel_rendering_suppressed_;
// The local display area for rendering the text.
Rect display_rect_;
« no previous file with comments | « ui/gfx/harfbuzz_font_skia.cc ('k') | ui/gfx/render_text.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698