Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 941503003: Revert "Remove IC age from Code." (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Remove IC age from Code." This reverts commit 3cd889 for regressing Kraken benchmark BUG=chromium:457174 LOG=N Committed: https://crrev.com/5242700da494d9fac6b3781bed5b7f3790c32335 Cr-Commit-Position: refs/heads/master@{#26740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -5 lines) Patch
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +11 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +100 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. I verified locally that this fixes kraken regression on nexus-5.
5 years, 10 months ago (2015-02-19 09:23:35 UTC) #2
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-19 09:24:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941503003/1
5 years, 10 months ago (2015-02-19 09:26:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 09:56:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 09:56:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5242700da494d9fac6b3781bed5b7f3790c32335
Cr-Commit-Position: refs/heads/master@{#26740}

Powered by Google App Engine
This is Rietveld 408576698