mac: Tentative fix for Yosemite open file crash.

chrome/browser/chrome_browser_main_mac.mm

Index: chrome/browser/chrome_browser_main_mac.mm
diff --git a/chrome/browser/chrome_browser_main_mac.mm b/chrome/browser/chrome_browser_main_mac.mm
index 4fcf17fef974337eaeb76ec902121e5d954f0844..ee5136fd94a129cb1cf6cb8611c9341354310280 100644
--- a/chrome/browser/chrome_browser_main_mac.mm
+++ b/chrome/browser/chrome_browser_main_mac.mm
@@ -259,7 +259,14 @@ void ChromeBrowserMainPartsMac::PreMainMessageLoopStart() {
       // in the window server, which is the default when not not using the
       // 10.9 SDK.
       // TODO: Remove this when we build with the 10.9 SDK.
-      @"NSWindowHostsLayersInWindowServer": @(base::mac::IsOSMavericksOrLater())
+      @"NSWindowHostsLayersInWindowServer":
+          @(base::mac::IsOSMavericksOrLater()),
+      // This setting prevents views from ditching their layers when the view
+      // gets removed from the view hierarchy. It defaults to YES for
+      // applications linked against an OSX 10.8+ SDK. In Yosemite, failing to
+      // set this to YES causes an AppKit crash. http://crbug.com/428977
+      // TODO(erikchen): Remove this when we build with an OSX 10.8+ SDK.
+      @"NSViewKeepLayersAround": @(YES),

[Avi (use Gerrit), 2015/02/18 22:40:52]

Can you use @YES here?

[erikchen, 2015/02/18 22:44:05]

Done.

There are two instances of @(YES) in the Chrome code base, and no instances of
@YES. Looking at the clang documentation
(http://clang.llvm.org/docs/ObjectiveCLiterals.html), @YES is more accurate as
it uses numberWithBool:. It's unclear what @(YES) gets compiled to.

   }];
 }