mac: Tentative fix for Yosemite open file crash.

mac: Tentative fix for Yosemite open file crash.

There's a bug in AppKit that causes Chrome to crash when users attempt to save
or open a file. The code path that causes the crash is only hit by applications
linked against OSX 10.7 SDK (or earlier). This CL registers a default value for
the preference NSViewKeepLayersAround, which prevents this code path from being
hit. The functional implications of changing the preference
NSViewKeepLayersAround are minimal.

BUG=428977
Committed: https://crrev.com/192b9d9cfe388a6cfb76b9aea56070da1d878a81
Cr-Commit-Position: refs/heads/master@{#316968}

[erikchen, 2015-02-18 22:25:41]

erikchen@chromium.org changed reviewers:
+ andresantoso@chromium.org

[erikchen, 2015-02-18 22:25:41]

Andre: Please review.

[erikchen, 2015-02-18 22:37:29]

On 2015/02/18 22:25:41, erikchen wrote:
> Andre: Please review.

Andre: PTAL

[Avi (use Gerrit), 2015-02-18 22:40:51]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-02-18 22:40:52]

https://codereview.chromium.org/941453002/diff/20001/chrome/browser/chrome_br...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/941453002/diff/20001/chrome/browser/chrome_br...
chrome/browser/chrome_browser_main_mac.mm:269: @"NSViewKeepLayersAround":
@(YES),
Can you use @YES here?

[Andre, 2015-02-18 22:41:34]

LGTM

[erikchen, 2015-02-18 22:42:28]

New patchsets have been uploaded after l-g-t-m from andresantoso@chromium.org

[Avi (use Gerrit), 2015-02-18 22:43:36]

On 2015/02/18 22:41:34, Andre wrote:
> LGTM

LGTM too

[erikchen, 2015-02-18 22:44:05]

https://codereview.chromium.org/941453002/diff/20001/chrome/browser/chrome_br...
File chrome/browser/chrome_browser_main_mac.mm (right):

https://codereview.chromium.org/941453002/diff/20001/chrome/browser/chrome_br...
chrome/browser/chrome_browser_main_mac.mm:269: @"NSViewKeepLayersAround":
@(YES),
On 2015/02/18 22:40:52, Avi wrote:
> Can you use @YES here?

Done.

There are two instances of @(YES) in the Chrome code base, and no instances of
@YES. Looking at the clang documentation
(http://clang.llvm.org/docs/ObjectiveCLiterals.html), @YES is more accurate as
it uses numberWithBool:. It's unclear what @(YES) gets compiled to.

[erikchen, 2015-02-18 22:44:43]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-18 22:46:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941453002/40001

[erikchen, 2015-02-18 23:55:41]

New patchsets have been uploaded after l-g-t-m from avi@chromium.org

[erikchen, 2015-02-18 23:57:46]

@YES doesn't work, since YES gets preprocessor defined to 1, and @YES becomes
@1.

[erikchen, 2015-02-18 23:57:54]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:59:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941453002/70001

[Andre, 2015-02-19 00:02:44]

On 2015/02/18 23:57:46, erikchen wrote:
> @YES doesn't work, since YES gets preprocessor defined to 1, and @YES becomes
> @1.

Looks like @YES requires 10.8 or later SDK
https://developer.apple.com/library/prerelease/ios/releasenotes/ObjectiveC/Ob...

[commit-bot: I haz the power, 2015-02-19 02:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-19 02:00:40]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[erikchen, 2015-02-19 02:04:02]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-02-19 02:05:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941453002/70001

[commit-bot: I haz the power, 2015-02-19 02:11:32]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2015-02-19 02:12:03]

Patchset 5 (id:??) landed as
https://crrev.com/192b9d9cfe388a6cfb76b9aea56070da1d878a81
Cr-Commit-Position: refs/heads/master@{#316968}

[Avi (use Gerrit), 2015-02-19 03:55:28]

On 2015/02/19 00:02:44, Andre wrote:
> On 2015/02/18 23:57:46, erikchen wrote:
> > @YES doesn't work, since YES gets preprocessor defined to 1, and @YES
becomes
> > @1.
> 
> Looks like @YES requires 10.8 or later SDK
>
https://developer.apple.com/library/prerelease/ios/releasenotes/ObjectiveC/Ob...

:(

Thanks anyway.

[erikchen, 2015-04-23 18:23:00]

A revert of this CL (patchset #5 id:70001) has been created in
https://codereview.chromium.org/1104733002/ by erikchen@chromium.org.

The reason for reverting is: Speculative revert. This CL might be responsible
for inverted text in omnibox.

https://code.google.com/p/chromium/issues/detail?id=479097.