Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 941433004: Remove LSan options/suppressions from recipe configs. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove LSan options/suppressions from recipe configs. Those are now compiled into the executable. BUG=302040 R=kjellander@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294197

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -72 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 1 2 chunks +0 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_tests.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/compile_failure_without_patch_with_test.json View 1 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.expected/full_tryserver_chromium_linux_linux_chromium_asan_rel.json View 3 chunks +0 lines, -3 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_linux_asan.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac_asan.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_mac_asan__xcode_6_1_.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_linux_asan.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_mac_asan_xcode61.json View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_asan__parallel_.json View 15 chunks +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 15 chunks +0 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 15 chunks +0 lines, -15 lines 0 comments Download
M scripts/slave/runtest.py View 1 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
earthdok
5 years, 10 months ago (2015-02-19 13:47:00 UTC) #1
kjellander_chromium
lgtm but you will need additional reviewers. I'll take care of cleaning up libyuv.
5 years, 10 months ago (2015-02-22 19:52:32 UTC) #2
earthdok
+Marc-Antoine
5 years, 10 months ago (2015-02-24 15:06:22 UTC) #4
M-A Ruel
I'm not a good reviewer for this but I can happily rubberstamp lgtm
5 years, 10 months ago (2015-02-24 15:16:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941433004/1
5 years, 10 months ago (2015-02-24 15:17:10 UTC) #7
commit-bot: I haz the power
Failed to apply patch for build/scripts/slave/recipe_modules/chromium/config.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 10 months ago (2015-02-24 15:17:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941433004/20001
5 years, 10 months ago (2015-02-24 15:24:20 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 15:30:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294197

Powered by Google App Engine
This is Rietveld 408576698