cc: Remove unused PictureDrawQuad support from GLRenderer.

cc: Remove unused PictureDrawQuad support from GLRenderer.

This eliminates one use of TextureUploader via
ResourceProvider::SetPixels.  The PICTURE_PILE_MODE is renamed to
OOM_MODE which more accurately describes what it is, and OOM tiles are
displayed in red again instead of gray (something that changed with
impl-side-painting).

R=enne
BUG=454575
Committed: https://crrev.com/66e4d216568639ad909b8477a9640a8e83369538
Cr-Commit-Position: refs/heads/master@{#316940}

[danakj, 2015-02-18 21:58:36]

Patchset #1 (id:1) has been deleted

[enne (OOO), 2015-02-18 22:23:02]

Do you think we'll never want OOM'd PictureDrawQuads (vs checkerboards) in the
browser compositor, where we would have a GLRenderer?

[danakj, 2015-02-18 22:23:58]

On 2015/02/18 22:23:02, enne wrote:
> Do you think we'll never want OOM'd PictureDrawQuads (vs checkerboards) in the
> browser compositor, where we would have a GLRenderer?

Checkerboards have never been a problem to date, except when we do bad things
that are bugs. So, no not really. If we do, we can revisit.

[enne (OOO), 2015-02-18 22:32:27]

https://codereview.chromium.org/941433002/diff/20001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/941433002/diff/20001/cc/BUILD.gn#newcode809
cc/BUILD.gn:809: "resources/platform_color_unittest.cc",
What's with the platform color unittest? Is that from some other change?

https://codereview.chromium.org/941433002/diff/20001/cc/debug/debug_colors.cc
File cc/debug/debug_colors.cc (right):

https://codereview.chromium.org/941433002/diff/20001/cc/debug/debug_colors.cc...
cc/debug/debug_colors.cc:133: // OOM tile borders are red.
style nit: Can you be consistent with the rest of the file by coming up with
some obscure color name for this? Like garnet or mahogany?

[danakj, 2015-02-18 22:33:39]

https://codereview.chromium.org/941433002/diff/20001/cc/BUILD.gn
File cc/BUILD.gn (right):

https://codereview.chromium.org/941433002/diff/20001/cc/BUILD.gn#newcode809
cc/BUILD.gn:809: "resources/platform_color_unittest.cc",
On 2015/02/18 22:32:27, enne wrote:
> What's with the platform color unittest? Is that from some other change?

I added that to replace the GLRendererPixelTest I removed.

[danakj, 2015-02-18 22:33:59]

https://codereview.chromium.org/941433002/diff/20001/cc/debug/debug_colors.cc
File cc/debug/debug_colors.cc (right):

https://codereview.chromium.org/941433002/diff/20001/cc/debug/debug_colors.cc...
cc/debug/debug_colors.cc:133: // OOM tile borders are red.
On 2015/02/18 22:32:27, enne wrote:
> style nit: Can you be consistent with the rest of the file by coming up with
> some obscure color name for this? Like garnet or mahogany?

LOL :D Sry copypasta

[enne (OOO), 2015-02-18 23:13:56]

lgtm

[danakj, 2015-02-18 23:24:16]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-02-18 23:25:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941433002/20001

[commit-bot: I haz the power, 2015-02-19 01:04:22]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-02-19 01:05:03]

Patchset 1 (id:??) landed as
https://crrev.com/66e4d216568639ad909b8477a9640a8e83369538
Cr-Commit-Position: refs/heads/master@{#316940}