Aura: New window shadows, desktop background debug toggle

Aura: New window shadows, desktop background debug toggle

+ Shadows support different appearances for active and inactive states.
+ Shadow opacity animates on activation change.
+ ImageGrid supports changing its images, allowing us to maintain our use of a single set of shadow layers per window.
+ Press control-alt-B in a debug build to reset the desktop background to a solid color, useful with a white background for testing shadows.
+ Window shadow art assets were added in an earlier revision.  

After this change lands I will delete the previous art assets, ui/resources/aura/shadow_rect_*

BUG=113075
TEST=aura_shell_unittests, added to ShadowControllerTest and ImageGridTest
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122547

Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=122551

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122618

[James Cook, 2012-02-16 23:57:00]

Dan, PTAL.

[Daniel Erat, 2012-02-17 00:18:31]

LGTM w/nits

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow.cc
File ash/wm/shadow.cc (right):

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow.cc#newcode39
ash/wm/shadow.cc:39: style_ == STYLE_ACTIVE ? kActiveShadowOpacity :
kInactiveShadowOpacity);
mind changing this to a switch statement with a NOTREACHED() default case, just
so it'll blow up if someone adds a new style later but forgets to update this?

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow.cc#newcode85
ash/wm/shadow.cc:85: if (style_ == STYLE_ACTIVE)
nit: change to a switch statement

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow_controller.cc
File ash/wm/shadow_controller.cc (right):

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow_controller.cc#new...
ash/wm/shadow_controller.cc:76: HandleWindowActivationChange(inactive, false);
mind moving the NULL check out of HandleWindowActivationChange() and putting it
here instead?

[James Cook, 2012-02-17 03:41:27]

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow.cc
File ash/wm/shadow.cc (right):

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow.cc#newcode39
ash/wm/shadow.cc:39: style_ == STYLE_ACTIVE ? kActiveShadowOpacity :
kInactiveShadowOpacity);
On 2012/02/17 00:18:32, Daniel Erat wrote:
> mind changing this to a switch statement with a NOTREACHED() default case,
just
> so it'll blow up if someone adds a new style later but forgets to update this?

Done.

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow.cc#newcode85
ash/wm/shadow.cc:85: if (style_ == STYLE_ACTIVE)
On 2012/02/17 00:18:32, Daniel Erat wrote:
> nit: change to a switch statement

Done.

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow_controller.cc
File ash/wm/shadow_controller.cc (right):

http://codereview.chromium.org/9414028/diff/1/ash/wm/shadow_controller.cc#new...
ash/wm/shadow_controller.cc:76: HandleWindowActivationChange(inactive, false);
On 2012/02/17 00:18:32, Daniel Erat wrote:
> mind moving the NULL check out of HandleWindowActivationChange() and putting
it
> here instead?

Done.

[James Cook, 2012-02-17 20:26:51]

Scott, can you OWNERS rubber-stamp the change to ui/resources/ui_resources.grd? 
I added the images yesterday, and will clean out the old ones after this change
lands.

[Daniel Erat, 2012-02-17 21:18:40]

(I think it's fine to TBR for rubber-stamp approval like this.)

On Fri, Feb 17, 2012 at 12:26,  <jamescook@chromium.org> wrote:
> Scott, can you OWNERS rubber-stamp the change to
> ui/resources/ui_resources.grd?
> I added the images yesterday, and will clean out the old ones after this
> change
> lands.
>
> http://codereview.chromium.org/9414028/

[commit-bot: I haz the power, 2012-02-17 21:25:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/9414028/8001

[James Cook, 2012-02-17 21:25:24]

OK, will TBR.  Sorry Scott.

[commit-bot: I haz the power, 2012-02-17 23:05:55]

Change committed as 122618