[Extensions] Fix extension toolbar crash

[Extensions] Fix extension toolbar crash

Sometimes the list of last known positions does not contain the full list of
extensions. Fix one such case, and account for any others.

BUG=460393
Committed: https://crrev.com/f4430c6e5c76320c2c0df593f848e1275d5c7b3c
Cr-Commit-Position: refs/heads/master@{#317428}

[Devlin, 2015-02-20 17:54:04]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-02-20 17:54:33]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-02-20 18:21:05]

rdevlin.cronin@chromium.org changed reviewers:
+ mek@chromium.org
- finnur@chromium.org

[Devlin, 2015-02-20 18:22:22]

Marijn, mind reviewing this real quick? Trying to get a crash fix in before
branch...

[Marijn Kruisselbrink, 2015-02-20 18:26:41]

https://codereview.chromium.org/941373002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_toolbar_model.cc (right):

https://codereview.chromium.org/941373002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_toolbar_model.cc:337:
static_cast<int>(last_known_positions_.size()));
I personally prefer std::min<int>(a, b) over std::min(a, static_cast<int>(b))
here, but both work equally well of course.

https://codereview.chromium.org/941373002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_toolbar_model.cc:465: // of ids at the end.
"and add it to the of ids at the end"? 
I think you forgot a word there.

[Devlin, 2015-02-20 21:49:12]

Patchset #2 (id:40001) has been deleted

[Devlin, 2015-02-20 21:50:00]

https://codereview.chromium.org/941373002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_toolbar_model.cc (right):

https://codereview.chromium.org/941373002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_toolbar_model.cc:337:
static_cast<int>(last_known_positions_.size()));
On 2015/02/20 18:26:41, Marijn Kruisselbrink wrote:
> I personally prefer std::min<int>(a, b) over std::min(a, static_cast<int>(b))
> here, but both work equally well of course.

Done.

https://codereview.chromium.org/941373002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_toolbar_model.cc:465: // of ids at the end.
On 2015/02/20 18:26:41, Marijn Kruisselbrink wrote:
> "and add it to the of ids at the end"? 
> I think you forgot a word there.

Done.

[Marijn Kruisselbrink, 2015-02-20 21:54:20]

lgtm

[Devlin, 2015-02-20 21:58:15]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-02-20 21:59:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941373002/60001

[commit-bot: I haz the power, 2015-02-20 22:34:33]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-02-20 22:35:37]

Patchset 2 (id:??) landed as
https://crrev.com/f4430c6e5c76320c2c0df593f848e1275d5c7b3c
Cr-Commit-Position: refs/heads/master@{#317428}