Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 941353002: [Android] Decouple AccessibilityInjector from WebContentsObserver (Closed)

Created:
5 years, 10 months ago by jdduke (slow)
Modified:
5 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Decouple AccessibilityInjector from WebContentsObserver Java-based WebContentsObservers can be relatively expensive, incurring JNI overhead, including necessary object conversions, for each callback. As AccessibilityInjector only relies on 2 observer methods, instead use ContentViewCore's observer to signal the necessary events. BUG=457748, 440134 Committed: https://crrev.com/f54cd4931b24a41ca835985db9c9c9db439fb5c5 Cr-Commit-Position: refs/heads/master@{#317376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jdduke (slow)
tedchoc@: PTAL. It looks like a few of our WebContentsObserver instances really only care about ...
5 years, 10 months ago (2015-02-20 16:58:55 UTC) #2
Ted C
lgtm -- in this instance it seems ok, but I don't want to tightly couple ...
5 years, 10 months ago (2015-02-20 17:38:58 UTC) #3
jdduke (slow)
On 2015/02/20 17:38:58, Ted C wrote: > lgtm -- in this instance it seems ok, ...
5 years, 10 months ago (2015-02-20 18:56:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941353002/1
5 years, 10 months ago (2015-02-20 18:57:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 19:45:03 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:45:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f54cd4931b24a41ca835985db9c9c9db439fb5c5
Cr-Commit-Position: refs/heads/master@{#317376}

Powered by Google App Engine
This is Rietveld 408576698