Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 941343002: Update documentation for vpnProvider (Closed)

Created:
5 years, 10 months ago by kaliamoorthi
Modified:
5 years, 10 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update documentation for vpnProvider This CL updates the documentation for vpnProvider interface to reflect the behavior of the API. BUG=459609 TBR=kalman@chromium.org Committed: https://crrev.com/64d88feb786ce07f5d40e5d66f15c6997a011bd4 Cr-Commit-Position: refs/heads/master@{#317343}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improves the documentation #

Total comments: 3

Patch Set 3 : Fixes nits from Bartosz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M extensions/common/api/vpn_provider.idl View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
kaliamoorthi
5 years, 10 months ago (2015-02-20 16:24:46 UTC) #2
bartfab (slow)
https://codereview.chromium.org/941343002/diff/1/extensions/common/api/vpn_provider.idl File extensions/common/api/vpn_provider.idl (right): https://codereview.chromium.org/941343002/diff/1/extensions/common/api/vpn_provider.idl#newcode25 extensions/common/api/vpn_provider.idl:25: // tunnel. By default all user traffic is routed ...
5 years, 10 months ago (2015-02-20 16:34:32 UTC) #3
kaliamoorthi
PTAL
5 years, 10 months ago (2015-02-20 16:52:45 UTC) #4
bartfab (slow)
https://codereview.chromium.org/941343002/diff/20001/extensions/common/api/vpn_provider.idl File extensions/common/api/vpn_provider.idl (right): https://codereview.chromium.org/941343002/diff/20001/extensions/common/api/vpn_provider.idl#newcode25 extensions/common/api/vpn_provider.idl:25: // eliminated and the exact duplicate entry that would ...
5 years, 10 months ago (2015-02-20 16:56:53 UTC) #5
kaliamoorthi
On 2015/02/20 16:56:53, bartfab wrote: > https://codereview.chromium.org/941343002/diff/20001/extensions/common/api/vpn_provider.idl > File extensions/common/api/vpn_provider.idl (right): > > https://codereview.chromium.org/941343002/diff/20001/extensions/common/api/vpn_provider.idl#newcode25 > ...
5 years, 10 months ago (2015-02-20 17:01:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941343002/40001
5 years, 10 months ago (2015-02-20 17:02:07 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-20 17:27:26 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 17:28:06 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/64d88feb786ce07f5d40e5d66f15c6997a011bd4
Cr-Commit-Position: refs/heads/master@{#317343}

Powered by Google App Engine
This is Rietveld 408576698