Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 941313003: ES6: Fix GetIterator (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6: Fix GetIterator After further spec reading it turns out that we should not do ToObject on the iterable. BUG=None LOG=N R=adamk Committed: https://crrev.com/fa1523ea6e2df562c39fee929b905ff5f7773e62 Cr-Commit-Position: refs/heads/master@{#26786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/v8natives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/collections.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-20 17:00:24 UTC) #1
adamk
lgtm
5 years, 10 months ago (2015-02-20 19:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941313003/1
5 years, 10 months ago (2015-02-20 20:06:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:07:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:07:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:07:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa1523ea6e2df562c39fee929b905ff5f7773e62
Cr-Commit-Position: refs/heads/master@{#26786}

Powered by Google App Engine
This is Rietveld 408576698