Issue 941243002: Remove CustomEvent from Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 941243002: Remove CustomEvent from Sky (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
esprehn, ojan

CC:
esprehn, eseidel, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove CustomEvent from Sky There's no point in CustomEvent anymore because authors can just subclass Event themselves. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/333904d0f9498857c6f0e73caf23de540c8ffaf5

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -143 lines)			Patch
M	sky/engine/build/scripts/make_event_factory.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/core.gni	View	3 chunks	+0 lines, -4 lines	0 comments	Download
D	sky/engine/core/events/CustomEvent.h	View	1 chunk	+0 lines, -59 lines	0 comments	Download
D	sky/engine/core/events/CustomEvent.cpp	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	sky/engine/core/events/CustomEvent.idl	View	1 chunk	+0 lines, -29 lines	0 comments	Download

Total messages: 5 (1 generated)

abarth-chromium

5 years, 10 months ago (2015-02-20 07:24:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
333904d0f9498857c6f0e73caf23de540c8ffaf5 (presubmit successful).