Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 941243002: Remove CustomEvent from Sky (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
esprehn, ojan
CC:
esprehn, eseidel, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove CustomEvent from Sky There's no point in CustomEvent anymore because authors can just subclass Event themselves. R=esprehn@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/333904d0f9498857c6f0e73caf23de540c8ffaf5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -143 lines) Patch
M sky/engine/build/scripts/make_event_factory.py View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/core.gni View 3 chunks +0 lines, -4 lines 0 comments Download
D sky/engine/core/events/CustomEvent.h View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/engine/core/events/CustomEvent.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
D sky/engine/core/events/CustomEvent.idl View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-20 07:21:20 UTC) #1
ojan
lgtm
5 years, 10 months ago (2015-02-20 07:22:59 UTC) #2
esprehn
lgtm
5 years, 10 months ago (2015-02-20 07:22:59 UTC) #4
abarth-chromium
5 years, 10 months ago (2015-02-20 07:24:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
333904d0f9498857c6f0e73caf23de540c8ffaf5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698