Fix regression from r317126 that caused a DCHECK in ResourceDispatcher.

Fix regression from r317126 that caused a DCHECK in ResourceDispatcher.

Previously WebURLLoaderImpl would keep track of cancelling the request by reseting bridge_. Now that we use request_id_ there instead, we need to do the same and reset its value.

BUG=460335, 338338
Committed: https://crrev.com/a484b301ffe721cdce66a5c91115d09dd3c7ac86
Cr-Commit-Position: refs/heads/master@{#317349}

[jam, 2015-02-20 06:01:12]

jam@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2015-02-20 17:52:51]

I don't know this code but it seems LGTM based on filtering out calls to the
ResourceDispatcher with a request_id of -1. One comment on a behavioral change.

https://codereview.chromium.org/941223002/diff/1/content/child/web_url_loader...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/941223002/diff/1/content/child/web_url_loader...
content/child/web_url_loader_impl.cc:378:
resource_dispatcher_->Cancel(request_id_);
Is it OK that we'll potentially send a -1 request_id_ to
resource_dispatcher_->Cancel() now?

[jam, 2015-02-20 17:56:29]

https://codereview.chromium.org/941223002/diff/1/content/child/web_url_loader...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/941223002/diff/1/content/child/web_url_loader...
content/child/web_url_loader_impl.cc:378:
resource_dispatcher_->Cancel(request_id_);
On 2015/02/20 17:52:51, Ken Russell wrote:
> Is it OK that we'll potentially send a -1 request_id_ to
> resource_dispatcher_->Cancel() now?

How could that happen? This if statement is guarded by a check against -1.

[Ken Russell (switch to Gerrit), 2015-02-20 17:57:30]

https://codereview.chromium.org/941223002/diff/1/content/child/web_url_loader...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/941223002/diff/1/content/child/web_url_loader...
content/child/web_url_loader_impl.cc:378:
resource_dispatcher_->Cancel(request_id_);
On 2015/02/20 17:56:29, jam wrote:
> On 2015/02/20 17:52:51, Ken Russell wrote:
> > Is it OK that we'll potentially send a -1 request_id_ to
> > resource_dispatcher_->Cancel() now?
> 
> How could that happen? This if statement is guarded by a check against -1.

Ah, sorry, I read the diffs backward and thought you had removed the test
against -1.

[jam, 2015-02-20 17:59:48]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-02-20 18:00:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941223002/1

[commit-bot: I haz the power, 2015-02-20 18:19:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-20 18:19:53]

Patchset 1 (id:??) landed as
https://crrev.com/a484b301ffe721cdce66a5c91115d09dd3c7ac86
Cr-Commit-Position: refs/heads/master@{#317349}