Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 941213005: Immediately "optimize as prototype" when setting as prototype of a function. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Immediately "optimize as prototype" when setting as prototype of a function. This saves space since OptimizeAsPrototype detaches from the transition tree, reclaiming intermediate maps. On gmail this corresponds to roughly 20% of all maps. BUG= Committed: https://crrev.com/fade797d02a2c3da305004803eccc45ea9b103e2 Cr-Commit-Position: refs/heads/master@{#26772}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -35 lines) Patch
M src/objects.cc View 1 2 3 chunks +40 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-20 10:34:36 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-20 11:12:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941213005/40001
5 years, 10 months ago (2015-02-20 11:53:30 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-20 12:24:01 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 12:24:29 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fade797d02a2c3da305004803eccc45ea9b103e2
Cr-Commit-Position: refs/heads/master@{#26772}

Powered by Google App Engine
This is Rietveld 408576698