Add keyboard navigation to the custom launcher page on app list start page.

Add keyboard navigation to the custom launcher page on app list start page.

This CL makes it possible to navigate to the custom launcher page from
the start page using the keyboard.

BUG=458884

[calamity, 2015-02-20 05:17:44]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2015-02-20 05:49:26]

lgtm with nits and changing the width.

Ick, this is pretty messy but I don't really see a better way of managing the
selection on the start page without a big refactor.

https://codereview.chromium.org/941213003/diff/1/ui/app_list/app_list_model.h
File ui/app_list/app_list_model.h (right):

https://codereview.chromium.org/941213003/diff/1/ui/app_list/app_list_model.h...
ui/app_list/app_list_model.h:140: }
nit: Blank line.

https://codereview.chromium.org/941213003/diff/1/ui/app_list/views/start_page...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/941213003/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:47: const int kLauncherPageBackgroundWidth
= 250;
Needs to be at least 350px wide (plus a bit of a buffer). Currently it is too
small. Make it 400.

https://codereview.chromium.org/941213003/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:85: }
nit: Blank line.

[calamity, 2015-02-20 06:56:59]

New patchsets have been uploaded after l-g-t-m from mgiuca@chromium.org

[calamity, 2015-02-20 06:57:22]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-02-20 06:57:44]

https://codereview.chromium.org/941213003/diff/1/ui/app_list/app_list_model.h
File ui/app_list/app_list_model.h (right):

https://codereview.chromium.org/941213003/diff/1/ui/app_list/app_list_model.h...
ui/app_list/app_list_model.h:140: }
On 2015/02/20 05:49:26, Matt Giuca wrote:
> nit: Blank line.

Done.

https://codereview.chromium.org/941213003/diff/1/ui/app_list/views/start_page...
File ui/app_list/views/start_page_view.cc (right):

https://codereview.chromium.org/941213003/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:47: const int kLauncherPageBackgroundWidth
= 250;
On 2015/02/20 05:49:26, Matt Giuca wrote:
> Needs to be at least 350px wide (plus a bit of a buffer). Currently it is too
> small. Make it 400.

Done.

https://codereview.chromium.org/941213003/diff/1/ui/app_list/views/start_page...
ui/app_list/views/start_page_view.cc:85: }
On 2015/02/20 05:49:26, Matt Giuca wrote:
> nit: Blank line.

Done.

[commit-bot: I haz the power, 2015-02-20 06:58:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941213003/20001

[commit-bot: I haz the power, 2015-02-20 07:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 07:00:59]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2015-02-20 11:16:07]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-20 11:17:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941213003/20001

[commit-bot: I haz the power, 2015-02-20 11:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-20 11:20:10]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Matt Giuca, 2015-02-20 12:07:39]

I can't upload a new patch set into this CL to fix the conflict so I had to
create a new CL:
https://codereview.chromium.org/924193005/

[Matt Giuca, 2015-02-20 12:20:47]

Closed to avoid confusion (I am committing
https://codereview.chromium.org/924193005/).