sky/engine/bindings/dart_event_listener.cc - Issue 941153003: Add dart_invoke to tonic for calls into App code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/dart_event_listener.cc

Issue 941153003: Add dart_invoke to tonic for calls into App code. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/dart_event_listener.cc

diff --git a/sky/engine/bindings/dart_event_listener.cc b/sky/engine/bindings/dart_event_listener.cc

index 2c16f656c8efe62938fc3b3b3985d2cbf725984c..b37344901786565decf8285797ac223d48ac4105 100644

--- a/sky/engine/bindings/dart_event_listener.cc

+++ b/sky/engine/bindings/dart_event_listener.cc

@@ -10,6 +10,7 @@

#include "sky/engine/tonic/dart_error.h"

#include "sky/engine/tonic/dart_exception_factory.h"

#include "sky/engine/tonic/dart_gc_visitor.h"

+#include "sky/engine/tonic/dart_invoke.h"

#include "sky/engine/tonic/dart_isolate_scope.h"

namespace blink {

@@ -51,7 +52,7 @@ void DartEventListener::handleEvent(ExecutionContext* context, Event* event) {

DCHECK(event_handle);

Dart_Handle params[] = {event_handle};

- LogIfError(Dart_InvokeClosure(closure_handle, arraysize(params), params));

+ DartInvokeAppClosure(closure_handle, arraysize(params), params);

}

void DartEventListener::AcceptDartGCVisitor(DartGCVisitor& visitor) const {