chrome/browser/ui/views/global_error_bubble_view.h - Issue 941133002: Update global error bubble view's boundary (position and size) after loading elevation icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.h

Issue 941133002: Update global error bubble view's boundary (position and size) after loading elevation icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/elevation_icon_setter.cc ('k') | chrome/browser/ui/views/global_error_bubble_view.cc » ('j') | chrome/browser/ui/views/global_error_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/global_error_bubble_view.h

diff --git a/chrome/browser/ui/views/global_error_bubble_view.h b/chrome/browser/ui/views/global_error_bubble_view.h

index 33ab6ce2c0ca22f39542f8281d831cfadf971b55..fac38486af26406af41cdb95c29767aa95d8ee41 100644

--- a/chrome/browser/ui/views/global_error_bubble_view.h

+++ b/chrome/browser/ui/views/global_error_bubble_view.h

@@ -14,9 +14,11 @@ class Browser;

class ElevationIconSetter;

class GlobalErrorWithStandardBubble;

-class GlobalErrorBubbleView : public views::ButtonListener,

- public views::BubbleDelegateView,

- public GlobalErrorBubbleViewBase {

+class GlobalErrorBubbleView

+ : public views::ButtonListener,

+ public views::BubbleDelegateView,

+ public base::SupportsWeakPtr<GlobalErrorBubbleView>,

+ public GlobalErrorBubbleViewBase {

public:

GlobalErrorBubbleView(

views::View* anchor_view,

@@ -37,6 +39,9 @@ class GlobalErrorBubbleView : public views::ButtonListener,

// GlobalErrorBubbleViewBase implementation.

void CloseBubbleView() override;

+ // Update bubble bound when needed (for example, after elevation icon is set).

+ void UpdateBound();

private:

Browser* browser_;

base::WeakPtr<GlobalErrorWithStandardBubble> error_;