Update global error bubble view's boundary (position and size) after loading elevation icon.

chrome/browser/ui/views/global_error_bubble_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/global_error_bubble_view.h"
 
 #include <vector>
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/global_error/global_error.h"
@@ skipping 84 matching lines @@
     message_labels.push_back(message_label);
   }
 
   base::string16 accept_string(error_->GetBubbleViewAcceptButtonLabel());
   scoped_ptr<views::LabelButton> accept_button(
       new views::LabelButton(this, accept_string));
   accept_button->SetStyle(views::Button::STYLE_BUTTON);
   accept_button->SetIsDefault(true);
   accept_button->set_tag(TAG_ACCEPT_BUTTON);
   if (error_->ShouldAddElevationIconToAcceptButton())
-    elevation_icon_setter_.reset(new ElevationIconSetter(accept_button.get()));
+    elevation_icon_setter_.reset(
+        new ElevationIconSetter(
+            accept_button.get(),
+            base::Bind(&GlobalErrorBubbleView::UpdateBound, AsWeakPtr())));

[Peter Kasting, 2015/02/21 01:06:27]

Why not just pass &views::BubbleDelegateView::SizeToContents() directly and
avoid adding the UpdateBound() function?

[xiaoling, 2015/02/21 01:15:00]

Because the function is the protected. Is there any trick to get around that?

[Peter Kasting, 2015/02/21 01:21:49]

Sorry, try passing &GlobalErrorBubbleView::SizeToContents instead.  That ought
to work.

[xiaoling, 2015/02/23 18:19:41]

Thanks for the trick. It worked, although I'm not clear why.

 
   base::string16 cancel_string(error_->GetBubbleViewCancelButtonLabel());
   scoped_ptr<views::LabelButton> cancel_button;
   if (!cancel_string.empty()) {
     cancel_button.reset(new views::LabelButton(this, cancel_string));
     cancel_button->SetStyle(views::Button::STYLE_BUTTON);
     cancel_button->set_tag(TAG_CANCEL_BUTTON);
   }
 
   views::GridLayout* layout = new views::GridLayout(this);
@@ skipping 46 matching lines @@
   // Adjust the message label size in case buttons are too long.
   for (size_t i = 0; i < message_labels.size(); ++i)
     message_labels[i]->SizeToFit(layout->GetPreferredSize(this).width());
 
   // These bubbles show at times where activation is sporadic (like at startup,
   // or a new window opening). Make sure the bubble doesn't disappear before the
   // user sees it, if the bubble needs to be acknowledged.
   set_close_on_deactivate(error_->ShouldCloseOnDeactivate());
 }
 
+void GlobalErrorBubbleView::UpdateBound() {
+  views::BubbleDelegateView::SizeToContents();
+}
+
 GlobalErrorBubbleView::~GlobalErrorBubbleView() {
   // |elevation_icon_setter_| references |accept_button_|, so make sure it is
   // destroyed before |accept_button_|.
   elevation_icon_setter_.reset();
 }
 
 void GlobalErrorBubbleView::ButtonPressed(views::Button* sender,
                                           const ui::Event& event) {
   if (error_) {
     if (sender->tag() == TAG_ACCEPT_BUTTON)
@@ skipping 11 matching lines @@
     error_->BubbleViewDidClose(browser_);
 }
 
 bool GlobalErrorBubbleView::ShouldShowCloseButton() const {
   return error_ && error_->ShouldShowCloseButton();
 }
 
 void GlobalErrorBubbleView::CloseBubbleView() {
   GetWidget()->Close();
 }