Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 941113002: Pass FrameTreeNode (not RenderFrameHost) to NavigateToEntry. (Closed)

Created:
5 years, 10 months ago by Charlie Reis
Modified:
5 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass FrameTreeNode (not RenderFrameHost) to NavigateToEntry. This is primarily cleanup, since navigation is performed on frames that can change their RenderFrameHost over time. BUG=236848 TEST=No behavior change. Committed: https://crrev.com/2b4cc9395f191c01519d53056b144c010efb1e45 Cr-Commit-Position: refs/heads/master@{#317217}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M content/browser/frame_host/navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 4 chunks +6 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Charlie Reis
Another piece of cleanup from the draft session history CL. https://codereview.chromium.org/941113002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/941113002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode371 ...
5 years, 10 months ago (2015-02-19 23:44:27 UTC) #2
alexmos
LGTM https://codereview.chromium.org/941113002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/941113002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode350 content/browser/frame_host/navigator_impl.cc:350: RequestNavigation(frame_tree_node, Nit: seems like it should fit on ...
5 years, 10 months ago (2015-02-20 00:53:47 UTC) #3
Charlie Reis
Thanks! https://codereview.chromium.org/941113002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/941113002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode350 content/browser/frame_host/navigator_impl.cc:350: RequestNavigation(frame_tree_node, On 2015/02/20 00:53:47, alexmos wrote: > Nit: ...
5 years, 10 months ago (2015-02-20 00:58:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941113002/20001
5 years, 10 months ago (2015-02-20 00:59:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 02:04:17 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 02:04:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b4cc9395f191c01519d53056b144c010efb1e45
Cr-Commit-Position: refs/heads/master@{#317217}

Powered by Google App Engine
This is Rietveld 408576698