PDF : New factory function for SkPDFDevice

PDF : New factory function for SkPDFDevice

SkPDFDevice now has factory function that matches what callers need.

Committed: https://skia.googlesource.com/skia/+/a1f1ee98a1f6d0770f6243270ca2f0e6c92efaba

[hal.canary, 2015-02-20 01:21:10]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-02-20 01:21:11]

ptal

[hal.canary, 2015-02-20 01:21:27]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-02-20 01:22:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941023005/1

[commit-bot: I haz the power, 2015-02-20 01:22:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-20 07:22 UTC

[hal.canary, 2015-02-20 12:54:46]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-02-20 12:54:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941023005/20001

[commit-bot: I haz the power, 2015-02-20 12:54:53]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-20 18:54 UTC

[mtklein, 2015-02-20 13:03:06]

https://codereview.chromium.org/941023005/diff/20001/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/941023005/diff/20001/src/pdf/SkPDFShader.cpp#...
src/pdf/SkPDFShader.cpp:948: SkPDFDevice::CreateUnflipped(size, 72.0f, NULL));
dpi plumbing coming later?

[hal.canary, 2015-02-20 13:55:06]

https://codereview.chromium.org/941023005/diff/20001/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/941023005/diff/20001/src/pdf/SkPDFShader.cpp#...
src/pdf/SkPDFShader.cpp:948: SkPDFDevice::CreateUnflipped(size, 72.0f, NULL));
On 2015/02/20 13:03:05, mtklein wrote:
> dpi plumbing coming later?

Yes, along with Canon plumbing.  This just gets the interface right.

72 was the old default, so this commit changes nothing.

[mtklein, 2015-02-20 14:05:29]

lgtm

[hal.canary, 2015-02-20 14:10:28]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-02-20 14:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941023005/40001

[commit-bot: I haz the power, 2015-02-20 14:17:30]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a1f1ee98a1f6d0770f6243270ca2f0e6c92efaba