Issue 940993005: Cherry pick ios/neon fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 940993005: Cherry pick ios/neon fix (Closed)

Created:
5 years, 10 months ago by Johann

Modified:
5 years, 10 months ago

Reviewers:
Tom Finegan

CC:
wwcv, jzern, fgalligan1

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cherry pick ios/neon fix Use correct buffer size in vp8 subpixel variance In vp8_sub_pixel_variance8x8_neon the temp2 buffer is only initialized to kHeight8 * kWidth8. However, in the case that xoffset != 0 and yoffset == 0, var_filter_block2d_bil_w8 is called with output_width kHeight8PlusOne. Thanks to cmugurel for diagnosing and yulius for the patch. https://gerrit.chromium.org/gerrit/73650 BUG=webrtc:4190 TBR=tomfinegan@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/33bbffe8b3fa6d240ab7720f4f46854bd98d7198

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	source/libvpx/vp8/common/arm/neon/vp8_subpixelvariance_neon.c	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Johann

Committed patchset #1 (id:1) manually as 33bbffe8b3fa6d240ab7720f4f46854bd98d7198 (presubmit successful).

5 years, 10 months ago (2015-02-19 20:05:15 UTC) #1

Tom Finegan

5 years, 10 months ago (2015-02-19 21:01:12 UTC) #2

Message was sent while issue was closed.

On 2015/02/19 20:05:15, Johann wrote:
> Committed patchset #1 (id:1) manually as
> 33bbffe8b3fa6d240ab7720f4f46854bd98d7198 (presubmit successful).

lgtm

Expand Messages | Collapse Messages