Build the IRT with nacl-clang for x86

src/untrusted/irt/irt.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../../../build/common.gypi',
   ],
   'variables': {
     'irt_sources': [
@@ skipping 25 matching lines @@
       'irt_random.c',
       'irt_pnacl_translator.c',
 # support_srcs
       # We also get nc_init_private.c, nc_thread.c and nc_tsd.c via
       # #includes of .c files.
       '../pthread/nc_mutex.c',
       '../pthread/nc_condvar.c',
       '../nacl/sys_private.c',
       '../valgrind/dynamic_annotations.c',
     ],
+# On x86-64 we build the IRT with sandbox base-address hiding. This means that

[Mark Seaborn, 2015/03/19 20:54:48]

Nit: indent comment

[Derek Schuff, 2015/03/19 21:28:30]

Done.

+# all of its components must be built with LLVM's assembler. Currently the
+# unwinder library is built with nacl-gcc and so does not use base address
+# hiding. The IRT does not use exceptions, so we do not actually need the
+# unwinder at all. To prevent it from being linked into the IRT, we provide
+# stub implementations of its functions that are referenced from libc++abi
+# (which is built with exception handling enabled) and from crtbegin.c.
+    'stub_sources': [
+      '../../../pnacl/support/bitcode/unwind_stubs.c',
+      'frame_info_stubs.c',
+    ],
     'irt_nonbrowser': [
       'irt_core_resource.c',
       'irt_entry_core.c',
     ],
   },
   'targets': [
     {
       'target_name': 'irt_core_nexe',
       'type': 'none',
       'variables': {
@@ skipping 26 matching lines @@
     },
     {
       'target_name': 'irt_browser_lib',
       'type': 'none',
       'variables': {
         'nlib_target': 'libirt_browser.a',
         'build_glibc': 0,
         'build_newlib': 1,
         'build_irt': 1,
       },
-      'sources': ['<@(irt_sources)'],
+      'sources': ['<@(irt_sources)','<@(stub_sources)'],

[Mark Seaborn, 2015/03/19 20:54:48]

Nit: add space after comma

[Derek Schuff, 2015/03/19 21:28:30]

Done.

+      'conditions': [
+        # Disable stub sources on ARM
+        # TODO(dschuff): remove this when we switch to arm-nacl-clang
+        ['target_arch=="arm"', {
+          'variables': {
+            'stub_sources' : []

[Mark Seaborn, 2015/03/19 20:54:48]

Nit: would it be more idiomatic for the condition to add to "sources" rather
than overriding "stub_sources"?

[Derek Schuff, 2015/03/19 21:28:30]

I tried that, but maybe I didn't get the gyp syntax correct. What would be the
way to do that?

+          }
+        }],
+      ],
       'dependencies': [
         '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
         '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib_newlib',
       ],
     },
   ],
 }