Source/modules/webaudio/AudioNode.cpp - Issue 940963005: Revert of WebAudio: Fix AudioNode leak in a case that AudioNode is not disconnected from the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/AudioNode.cpp

Issue 940963005: Revert of WebAudio: Fix AudioNode leak in a case that AudioNode is not disconnected from the ... (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/AudioNode.cpp

diff --git a/Source/modules/webaudio/AudioNode.cpp b/Source/modules/webaudio/AudioNode.cpp

index f640cd4da5afd67746b41cd117b3675ce74c6f45..6733a0df59ec9fa6952b5a9ddf756c5e3784fccc 100644

--- a/Source/modules/webaudio/AudioNode.cpp

+++ b/Source/modules/webaudio/AudioNode.cpp

@@ -105,11 +105,6 @@

context()->disposeOutputs(*this);

for (unsigned i = 0; i < m_outputs.size(); ++i)

output(i)->disconnectAll();

- if (context()->contextState() != AudioContext::Running)

- return;

- ThreadState::current()->markAsZombie(this);

- context()->setLastZombie(this);

}

String AudioNode::nodeTypeName() const

« no previous file with comments | « Source/modules/webaudio/AudioContext.cpp ('k') | Source/modules/webaudio/AudioSummingJunction.cpp » ('j') | no next file with comments »