Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 940933002: Files.app: Re-design auto-complete suggestion list. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Re-design auto-complete suggestion list. BUG=402344, 458695 TEST=manually Committed: https://crrev.com/1a8aa27dafb948a6817ba9050722f5db49787006 Cr-Commit-Position: refs/heads/master@{#317050}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -44 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 3 chunks +20 lines, -26 lines 5 comments Download
M ui/file_manager/file_manager/foreground/js/ui/search_box.js View 3 chunks +0 lines, -17 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-19 14:08:19 UTC) #2
hirono
lgtm with nits, thanks! https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1637 ui/file_manager/file_manager/foreground/css/file_manager.css:1637: margin: 0 3px; Is it ...
5 years, 10 months ago (2015-02-19 14:25:28 UTC) #3
fukino
Thank you! https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1637 ui/file_manager/file_manager/foreground/css/file_manager.css:1637: margin: 0 3px; On 2015/02/19 14:25:28, hirono ...
5 years, 10 months ago (2015-02-19 14:27:35 UTC) #4
hirono
https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1637 ui/file_manager/file_manager/foreground/css/file_manager.css:1637: margin: 0 3px; On 2015/02/19 14:27:35, fukino wrote: > ...
5 years, 10 months ago (2015-02-19 14:29:29 UTC) #5
fukino
On 2015/02/19 14:29:29, hirono wrote: > https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css > File ui/file_manager/file_manager/foreground/css/file_manager.css (right): > > https://codereview.chromium.org/940933002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode1637 > ...
5 years, 10 months ago (2015-02-19 14:30:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940933002/1
5 years, 10 months ago (2015-02-19 14:30:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 15:00:30 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 15:01:17 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1a8aa27dafb948a6817ba9050722f5db49787006
Cr-Commit-Position: refs/heads/master@{#317050}

Powered by Google App Engine
This is Rietveld 408576698