dart2js: Implement instanceMembers and staticMembers.

dart2js: Implement instanceMembers and staticMembers.

BUG=http://dartbug.com/14633
R=ahe@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31757

[rmacnak, 2013-12-20 18:52:07]

Actually version the new tests...

[gbracha, 2013-12-20 19:05:39]

tests lgtm with minor comments

https://codereview.chromium.org/94093011/diff/40001/tests/lib/mirrors/declara...
File tests/lib/mirrors/declarations_model_easier.dart (right):

https://codereview.chromium.org/94093011/diff/40001/tests/lib/mirrors/declara...
tests/lib/mirrors/declarations_model_easier.dart:12: typedef bool
Predicate(dynamic);
You could write Predicate(Object) here and it would have no ill effect. I am
stylistically opposed to explicitly using dynamic as a type unless it is
strictly necessary.

https://codereview.chromium.org/94093011/diff/40001/tests/lib/mirrors/declara...
tests/lib/mirrors/declarations_model_easier.dart:51: extends Superclass<C>
implements Interface<C> {
Doesn't the analyzer complain that / is not implemented?

[ahe, 2014-01-13 17:12:43]

LGTM and thank you!

https://chromiumcodereview.appspot.com/94093011/diff/20001/sdk/lib/_internal/...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://chromiumcodereview.appspot.com/94093011/diff/20001/sdk/lib/_internal/...
sdk/lib/_internal/lib/js_mirrors.dart:1143: new _SyntheticAccessor(this,
getterName, true, false, false, decl);
Long line.

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1112: !decl.isConstructor &&
!decl.isAbstract) {
Why the case for isAbstract?

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1145: new _SyntheticAccessor(this,
getterName, true, false, false, decl);
Long line.

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1233: class _SyntheticAccessor implements
MethodMirror {
Rename to JsSyntheticAccessor.

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1233: class _SyntheticAccessor implements
MethodMirror {
How do I get from a synthetic accessor to the original field?

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1239: final _target;
Add type or comment explaining what _target is.

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1276: class _SyntheticSetterParameter
implements ParameterMirror {
Rename to JsSyntheticSetterParamter.

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1521: new _SyntheticAccessor(this,
getterName, true, false, false, decl);
Long line.

[rmacnak, 2014-01-13 18:30:46]

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1112: !decl.isConstructor &&
!decl.isAbstract) {
On 2014/01/13 17:12:43, ahe wrote:
> Why the case for isAbstract?

Generally, the idea was that instance/static/toplevelMembers describe the
callable API of an object.

We don't have abstract static members so this particular use is unnecessary.
Removed.

https://chromiumcodereview.appspot.com/94093011/diff/100001/sdk/lib/_internal...
sdk/lib/_internal/lib/js_mirrors.dart:1233: class _SyntheticAccessor implements
MethodMirror {
On 2014/01/13 17:12:43, ahe wrote:
> How do I get from a synthetic accessor to the original field?

We don't have any convenience method for that.

[rmacnak, 2014-01-13 21:09:58]

Committed patchset #5 manually as r31757 (presubmit successful).