Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 940913002: Show a vertical scrollbar (when needed) for overflow:-webkit-paged-y. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Show a vertical scrollbar (when needed) for overflow:-webkit-paged-y. We were already showing a horizontal scrollbar for -webkit-paged-x. For -webkit-paged-y, on the other hand, it only worked when it was the viewport that was paginated, but not when specified on a regular block. The CSS parser currently deals with the overflow shorthand in such a way that it's the overflow-y property that gets the -webkit-paged-foo value (while overflow-x becomes auto). Digression: While one could say that's not quite right when it comes to horizontal writing modes, handling shorthands based on writing mode would be nasty... Skipping 2 of the new tests for the old / current multicol implementation, since they fail there. All tests pass in the new implementation. BUG=460024 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -53 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-bt-ltr.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-bt-ltr-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-bt-rtl.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-bt-rtl-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-tb-ltr.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-tb-ltr-expected.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-tb-rtl.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-horizontal-tb-rtl-expected.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-lr-ltr.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-lr-ltr-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-lr-rtl.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-lr-rtl-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-rl-ltr.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-rl-ltr-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-rl-rtl.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/pagination/div-y-vertical-rl-rtl-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-23 12:42:23 UTC) #1
rune
lgtm The description should say why you skip the tests in TestExpectations.
5 years, 10 months ago (2015-02-23 13:29:22 UTC) #3
mstensho (USE GERRIT)
On 2015/02/23 13:29:22, rune wrote: > lgtm > > The description should say why you ...
5 years, 10 months ago (2015-02-23 13:31:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940913002/1
5 years, 10 months ago (2015-02-23 13:32:30 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 13:35:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190656

Powered by Google App Engine
This is Rietveld 408576698