Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 940873003: Add a more evil version of fast/multicol/table-cell-content-change.html (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
andersr
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a more evil version of fast/multicol/table-cell-content-change.html It's not really that evil, but still too much for the old / current multicol implementation to handle, because of an imperfect column balancing algorithm there. BUG=352052 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190485

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/multicol/table-cell-content-change.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/table-cell-content-change-expected.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html View 1 chunk +20 lines, -0 lines 2 comments Download
A LayoutTests/fast/multicol/table-cell-content-change-with-decorations-expected.html View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-19 13:37:33 UTC) #1
andersr
lgtm https://codereview.chromium.org/940873003/diff/1/LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html File LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html (right): https://codereview.chromium.org/940873003/diff/1/LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html#newcode11 LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html:11: <div style="-webkit-columns:2; -webkit-column-rule:1px solid; -webkit-column-gap:11px; width:511px; background:yellow;"> Is ...
5 years, 10 months ago (2015-02-19 16:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940873003/1
5 years, 10 months ago (2015-02-19 16:42:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190485
5 years, 10 months ago (2015-02-19 16:46:44 UTC) #5
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-19 16:47:05 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/940873003/diff/1/LayoutTests/fast/multicol/ta...
File LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html
(right):

https://codereview.chromium.org/940873003/diff/1/LayoutTests/fast/multicol/ta...
LayoutTests/fast/multicol/table-cell-content-change-with-decorations.html:11:
<div style="-webkit-columns:2; -webkit-column-rule:1px solid;
-webkit-column-gap:11px; width:511px; background:yellow;">
On 2015/02/19 16:36:09, andersr wrote:
> Is background:yellow there just to make the gap visible?

It's there to show the actual height of the multicol container. But the
column-rule also shows the actual height, so I don't really remember why I
decided to have both (which is something I did initially in
table-cell-content-change.html). But should pigs learn to fly, I suppose it
might serve a purpose. :) I'll just keep it.

Powered by Google App Engine
This is Rietveld 408576698