Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 940833002: With always-on enabled, always shut down the hotword detector after a trigger. (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 10 months ago
Reviewers:
kcarattini
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

With always-on enabled, always shut down the hotword detector after a trigger. This is because the hotword stream requires that it be closed and re-opened after triggering and currently, the only way to do this is to shutdown the detector since its stream cannot be replaced. BUG=403138 Committed: https://crrev.com/792cef165819a3dba7725ac42c349369b4cf60a4 Cr-Commit-Position: refs/heads/master@{#317023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/hotword/state_manager.js View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Anand Mistry (off Chromium)
5 years, 10 months ago (2015-02-19 04:31:36 UTC) #2
kcarattini
lgtm
5 years, 10 months ago (2015-02-19 05:56:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940833002/1
5 years, 10 months ago (2015-02-19 06:44:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/24490)
5 years, 10 months ago (2015-02-19 07:16:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940833002/1
5 years, 10 months ago (2015-02-19 10:10:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 10:42:27 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 10:43:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/792cef165819a3dba7725ac42c349369b4cf60a4
Cr-Commit-Position: refs/heads/master@{#317023}

Powered by Google App Engine
This is Rietveld 408576698