Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: content/browser/utility_process_host_impl.cc

Issue 940813003: Use a utility process for the Mojo v8 proxy resolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-pac-in-process-enable
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/utility_process_host_impl.cc
diff --git a/content/browser/utility_process_host_impl.cc b/content/browser/utility_process_host_impl.cc
index b859407e702b0e59ab250e821f631af29dd760e2..620fedaa60871574540f20960d813bb9eb99a4b0 100644
--- a/content/browser/utility_process_host_impl.cc
+++ b/content/browser/utility_process_host_impl.cc
@@ -9,12 +9,14 @@
#include "base/command_line.h"
#include "base/lazy_instance.h"
#include "base/message_loop/message_loop.h"
+#include "base/process/process_handle.h"
#include "base/run_loop.h"
#include "base/sequenced_task_runner.h"
#include "base/strings/utf_string_conversions.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
#include "content/browser/browser_child_process_host_impl.h"
+#include "content/browser/mojo/mojo_application_host.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/common/child_process_host_impl.h"
#include "content/common/utility_messages.h"
@@ -34,7 +36,8 @@ class UtilitySandboxedProcessLauncherDelegate
: public SandboxedProcessLauncherDelegate {
public:
UtilitySandboxedProcessLauncherDelegate(const base::FilePath& exposed_dir,
- bool launch_elevated, bool no_sandbox,
+ bool launch_elevated,
+ bool no_sandbox,
const base::EnvironmentMap& env,
ChildProcessHost* host)
: exposed_dir_(exposed_dir),
@@ -50,9 +53,7 @@ class UtilitySandboxedProcessLauncherDelegate
~UtilitySandboxedProcessLauncherDelegate() override {}
#if defined(OS_WIN)
- bool ShouldLaunchElevated() override {
- return launch_elevated_;
- }
+ bool ShouldLaunchElevated() override { return launch_elevated_; }
void PreSandbox(bool* disable_default_policy,
base::FilePath* exposed_dir) override {
*exposed_dir = exposed_dir_;
@@ -165,6 +166,16 @@ void UtilityProcessHostImpl::SetEnv(const base::EnvironmentMap& env) {
#endif // OS_POSIX
+bool UtilityProcessHostImpl::StartMojoMode() {
+ CHECK(!mojo_application_host_);
+ mojo_application_host_.reset(new MojoApplicationHost);
+ return StartProcess();
+}
+
+ServiceRegistry* UtilityProcessHostImpl::GetServiceRegistry() {
+ return mojo_application_host_->service_registry();
Sam McNally 2015/03/09 03:36:15 DCHECK(mojo_application_host_);
Anand Mistry (off Chromium) 2015/03/10 07:24:23 Done.
+}
+
bool UtilityProcessHostImpl::StartProcess() {
if (started_)
return true;
@@ -173,6 +184,12 @@ bool UtilityProcessHostImpl::StartProcess() {
if (is_batch_mode_)
return true;
+ if (mojo_application_host_) {
+ bool mojo_result = mojo_application_host_->Init();
Sam McNally 2015/03/09 03:36:15 Why not do this in StartMojoMode()?
Anand Mistry (off Chromium) 2015/03/10 07:24:24 No particular reason.
+ if (!mojo_result)
+ return false;
+ }
+
// Name must be set or metrics_service will crash in any test which
// launches a UtilityProcessHost.
process_.reset(new BrowserChildProcessHostImpl(PROCESS_TYPE_UTILITY, this));
@@ -292,4 +309,16 @@ void UtilityProcessHostImpl::OnProcessCrashed(int exit_code) {
exit_code));
}
+void UtilityProcessHostImpl::OnProcessLaunched() {
+ if (mojo_application_host_) {
+ base::ProcessHandle handle;
+ if (RenderProcessHost::run_renderer_in_process())
+ handle = base::GetCurrentProcessHandle();
+ else
+ handle = process_->GetData().handle;
+
+ mojo_application_host_->Activate(this, handle);
+ }
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698