Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: chrome/browser/net/proxy_browsertest.cc

Issue 940813003: Use a utility process for the Mojo v8 proxy resolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-pac-in-process-enable
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/proxy_browsertest.cc
diff --git a/chrome/browser/net/proxy_browsertest.cc b/chrome/browser/net/proxy_browsertest.cc
index d705a09521d02f77178932bfa8e7622be2042366..63919558b6889689e2821e2b8c63fe3481d39e1d 100644
--- a/chrome/browser/net/proxy_browsertest.cc
+++ b/chrome/browser/net/proxy_browsertest.cc
@@ -249,4 +249,30 @@ IN_PROC_BROWSER_TEST_F(DataProxyScriptBrowserTest, Verify) {
VerifyProxyScript(browser());
}
+// Fetch PAC script via a data: URL and run out-of-process using Mojo.
+class OutOfProcessProxyResolverBrowserTest : public InProcessBrowserTest {
+ public:
+ OutOfProcessProxyResolverBrowserTest() {}
+ ~OutOfProcessProxyResolverBrowserTest() override {}
+
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ std::string contents;
+ // Read in kPACScript contents.
+ ASSERT_TRUE(base::ReadFileToString(ui_test_utils::GetTestFilePath(
+ base::FilePath(base::FilePath::kCurrentDirectory),
+ base::FilePath(kPACScript)),
+ &contents));
+ command_line->AppendSwitchASCII(switches::kProxyPacUrl,
Sam McNally 2015/03/09 03:36:15 Wrap after ( or align the next line after it.
Anand Mistry (off Chromium) 2015/03/10 07:24:23 Done.
+ std::string("data:,") + contents);
Sam McNally 2015/03/09 03:36:15 Shouldn't need to construct a std::string here.
Anand Mistry (off Chromium) 2015/03/10 07:24:22 Done.
+ command_line->AppendSwitch(switches::kV8PacMojoOutOfProcess);
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(OutOfProcessProxyResolverBrowserTest);
+};
+
+IN_PROC_BROWSER_TEST_F(OutOfProcessProxyResolverBrowserTest, Verify) {
+ VerifyProxyScript(browser());
+}
+
} // namespace
« no previous file with comments | « no previous file | chrome/browser/net/proxy_service_factory.cc » ('j') | chrome/browser/net/proxy_service_factory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698