win: add equivalent of gettimeofday

win: add equivalent of gettimeofday

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/583314184abc30bd5f563d96fe3906e8b84fdaa2

[scottmg, 2015-02-19 01:19:38]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-02-19 01:19:43]

Patchset #1 (id:1) has been deleted

[Mark Mentovai, 2015-02-20 18:15:33]

Cool.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc
File util/win/time.cc (right):

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode22
util/win/time.cc:22: void GetTimeOfDay(timeval* tv) {
Maybe we want to do this in compat as gettimeofday() instead of here. That would
make more sense if there were cross-platform callers. If there aren’t, this is
fine.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode32
util/win/time.cc:32: const uint64_t kNumSecondsFrom1601To1970 = 11644473600;
This would be more convincing if it did the math in-line: (369 * 365 + 89) * (24
* 60 * 60).

(You could use 86400 for the last term, I recognize it and you did mention it in
the comment.)

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode33
util/win/time.cc:33: const uint64_t kMicrosecondsPerSecond = 1000000;
Counting zeroes is hard, use 1E6.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode34
util/win/time.cc:34: t -= kNumSecondsFrom1601To1970 * kMicrosecondsPerSecond;
DCHECK_GE(t, kNumSecondsFrom1601To1970) before subtracting.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.h
File util/win/time.h (right):

https://codereview.chromium.org/940793002/diff/60001/util/win/time.h#newcode22
util/win/time.h:22: void GetTimeOfDay(timeval* tv);
//! \brief to explain this just a little bit?

https://codereview.chromium.org/940793002/diff/60001/util/win/time_test.cc
File util/win/time_test.cc (right):

https://codereview.chromium.org/940793002/diff/60001/util/win/time_test.cc#ne...
util/win/time_test.cc:28: EXPECT_GT(approx_now + 100, t.tv_sec);
approx_now should always be strictly >= t.tv_sec. I don’t think you need the
addition here, as long as you change this from GT to GE.

[scottmg, 2015-02-20 19:27:56]

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc
File util/win/time.cc (right):

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode22
util/win/time.cc:22: void GetTimeOfDay(timeval* tv) {
On 2015/02/20 18:15:33, Mark Mentovai wrote:
> Maybe we want to do this in compat as gettimeofday() instead of here. That
would
> make more sense if there were cross-platform callers. If there aren’t, this is
> fine.

There isn't at the moment, so I'll leave it here. We can always move it later.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode32
util/win/time.cc:32: const uint64_t kNumSecondsFrom1601To1970 = 11644473600;
On 2015/02/20 18:15:33, Mark Mentovai wrote:
> This would be more convincing if it did the math in-line: (369 * 365 + 89) *
(24
> * 60 * 60).
> 
> (You could use 86400 for the last term, I recognize it and you did mention it
in
> the comment.)

Done.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode33
util/win/time.cc:33: const uint64_t kMicrosecondsPerSecond = 1000000;
On 2015/02/20 18:15:33, Mark Mentovai wrote:
> Counting zeroes is hard, use 1E6.

Done.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.cc#newcode34
util/win/time.cc:34: t -= kNumSecondsFrom1601To1970 * kMicrosecondsPerSecond;
On 2015/02/20 18:15:33, Mark Mentovai wrote:
> DCHECK_GE(t, kNumSecondsFrom1601To1970) before subtracting.

Done.

https://codereview.chromium.org/940793002/diff/60001/util/win/time.h
File util/win/time.h (right):

https://codereview.chromium.org/940793002/diff/60001/util/win/time.h#newcode22
util/win/time.h:22: void GetTimeOfDay(timeval* tv);
On 2015/02/20 18:15:33, Mark Mentovai wrote:
> //! \brief to explain this just a little bit?

Done.

https://codereview.chromium.org/940793002/diff/60001/util/win/time_test.cc
File util/win/time_test.cc (right):

https://codereview.chromium.org/940793002/diff/60001/util/win/time_test.cc#ne...
util/win/time_test.cc:28: EXPECT_GT(approx_now + 100, t.tv_sec);
On 2015/02/20 18:15:33, Mark Mentovai wrote:
> approx_now should always be strictly >= t.tv_sec. I don’t think you need the
> addition here, as long as you change this from GT to GE.

Done.

[Mark Mentovai, 2015-02-20 19:34:18]

LGTM

[scottmg, 2015-02-20 19:35:09]

Committed patchset #3 (id:80001) manually as
583314184abc30bd5f563d96fe3906e8b84fdaa2 (presubmit successful).