Issue 940783003: Revert of Fix Presentation API mocks: do not eagerly drop clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 940783003: Revert of Fix Presentation API mocks: do not eagerly drop clients. (Closed)

Created:
5 years, 10 months ago by bungeman-skia

Modified:
5 years, 10 months ago

Reviewers:
whywhat, Mike West, mlamouri (slow - plz ping)

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix Presentation API mocks: do not eagerly drop clients. (patchset #2 id:20001 of https://codereview.chromium.org/938033002/) Reason for revert: This change appears to be causing failures in running layout tests ('webkit_tests' step) of Windows 7 and Linux debug builds. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/1363 or http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9658 . Original issue's description: > Fix Presentation API mocks: do not drop eagerly drop clients. > > BUG=412331 > > Committed: https://crrev.com/4ff204b8d2637af0abd8a05485e5941af8ef4271 > Cr-Commit-Position: refs/heads/master@{#317057} TBR=mkwst@chromium.org,avayvod@chromium.org,mlamouri@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=412331 Committed: https://crrev.com/10fd451684d0d89ceef6a491fa105f89b9a9862c Cr-Commit-Position: refs/heads/master@{#317099}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	content/shell/renderer/test_runner/mock_presentation_client.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	content/shell/renderer/test_runner/mock_presentation_service.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

bungeman-skia

Created Revert of Fix Presentation API mocks: do not eagerly drop clients.

5 years, 10 months ago (2015-02-19 19:22:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940783003/1

5 years, 10 months ago (2015-02-19 19:24:27 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 19:27:08 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/10fd451684d0d89ceef6a491fa105f89b9a9862c
Cr-Commit-Position: refs/heads/master@{#317099}