Issue 940783002: Cleanup: Remove wstring methods from base::Pickle.

Issue 940783002: Cleanup: Remove wstring methods from base::Pickle. (Closed)

Created:
5 years, 10 months ago by Lei Zhang

Modified:
5 years, 9 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Cleanup: Remove wstring methods from base::Pickle. BUG=23581 Committed: https://crrev.com/f84f17fad17e48146cf6894916a38801b4bdd6ec Cr-Commit-Position: refs/heads/master@{#320140}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -92 lines)			Patch
M	base/pickle.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	base/pickle.cc	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	base/pickle_unittest.cc	View	5 chunks	+5 lines, -17 lines	0 comments	Download
M	ipc/ipc_channel_unittest.cc	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	ipc/ipc_fuzzing_tests.cc	View	12 chunks	+27 lines, -24 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	ipc/ipc_message_utils.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 10 (5 generated)

Lei Zhang

Our code is sufficiently wstring free such that nobody is using these methods anymore, other ...

5 years, 9 months ago (2015-03-10 23:26:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940783002/60001

5 years, 9 months ago (2015-03-11 19:38:32 UTC) #8

commit-bot: I haz the power

5 years, 9 months ago (2015-03-11 20:42:52 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f84f17fad17e48146cf6894916a38801b4bdd6ec
Cr-Commit-Position: refs/heads/master@{#320140}