Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 940753002: accessibility: Simpler AXTree root accessor. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

accessibility: Simpler AXTree root accessor. - It does not need to be virtual. - Since it is a simple getter accessor it can be inlined in the header file and thus renamed to just root(). BUG=None R=dmazzoni@chromium.org,avi@chromium.org TBR=dtseng@chromium.org Committed: https://crrev.com/6b1c1e08e82080c9b7a15bd5f3651b6e56df8cde Cr-Commit-Position: refs/heads/master@{#317444}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : more fixes #

Patch Set 4 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/accessibility_ipc_error_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/cross_platform_accessibility_browsertest.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_generated_tree_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/ax_serializable_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_tree.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M ui/accessibility/ax_tree_serializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
tfarina
5 years, 10 months ago (2015-02-19 20:14:27 UTC) #1
dmazzoni
lgtm
5 years, 10 months ago (2015-02-20 00:42:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940753002/60001
5 years, 10 months ago (2015-02-20 00:54:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44055)
5 years, 10 months ago (2015-02-20 01:00:56 UTC) #6
tfarina
Avi, could you approve the content/ changes?
5 years, 10 months ago (2015-02-20 01:03:05 UTC) #8
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-20 20:25:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940753002/60001
5 years, 10 months ago (2015-02-20 20:27:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 10 months ago (2015-02-20 22:28:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940753002/60001
5 years, 10 months ago (2015-02-20 22:34:24 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44374)
5 years, 10 months ago (2015-02-20 23:04:56 UTC) #17
tfarina
TBRing David for trivial changes in chrome/browser/extensions/api/automation/
5 years, 10 months ago (2015-02-20 23:24:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940753002/60001
5 years, 10 months ago (2015-02-20 23:25:51 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-20 23:47:14 UTC) #22
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 23:48:11 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b1c1e08e82080c9b7a15bd5f3651b6e56df8cde
Cr-Commit-Position: refs/heads/master@{#317444}

Powered by Google App Engine
This is Rietveld 408576698