Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: sky/specs/elements.md

Issue 940743002: Specs: We should rename insertBefore(), but anyone got a suggestion for a better-sounding name? (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/elements.md
diff --git a/sky/specs/elements.md b/sky/specs/elements.md
index 9a88f5a27b8a30cba6329b832b0c8007ae896844..8e53d45d809ec0f77efdbb7859cc1bceb7e6c448 100644
--- a/sky/specs/elements.md
+++ b/sky/specs/elements.md
@@ -39,6 +39,10 @@ abstract class Node extends EventTarget {
return result as Element;
}
+ // TODO(ianh): rename insertBefore() and insertAfter() since the Web
+ // has an insertBefore() that means something else. What's a good
+ // name, though?
+
external void _insertBefore(Node node); // O(N) in number of descendants
// node must be Text or Element, parentNode must be non-null
void insertBefore(List nodes) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698