Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 940733002: Mac: Add more components of double-tap zoom. (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Add more components of double-tap zoom. This was reverted due to high crash rates on 10.10.2 (where we don't full crash reports). This was tested on branch and didn't affect the crash rate. The next step is to forward the event to the renderer. BUG=452592 Committed: https://crrev.com/2fd70de72b35f144c1e604f22011f2d6e8b19b7c Cr-Commit-Position: refs/heads/master@{#316934}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +3 lines, -0 lines 1 comment Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
(next step in the debug-by-crash-rate saga).
5 years, 10 months ago (2015-02-18 21:06:39 UTC) #2
Avi (use Gerrit)
lgtm https://codereview.chromium.org/940733002/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/940733002/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode2282 content/browser/renderer_host/render_widget_host_view_mac.mm:2282: ignore_result(smartMagnifyEvent); Heh!
5 years, 10 months ago (2015-02-18 21:32:10 UTC) #3
ccameron
Thanks!
5 years, 10 months ago (2015-02-18 21:37:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940733002/1
5 years, 10 months ago (2015-02-18 21:38:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 00:40:48 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 00:41:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2fd70de72b35f144c1e604f22011f2d6e8b19b7c
Cr-Commit-Position: refs/heads/master@{#316934}

Powered by Google App Engine
This is Rietveld 408576698