Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 940723002: Fix Autofill crash on mac address book entries (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Autofill crash on mac address book entries BUG=459688 Committed: https://crrev.com/40304324a852eaedfefb037b300a378c2800d97c Cr-Commit-Position: refs/heads/master@{#316976}

Patch Set 1 #

Total comments: 2

Patch Set 2 : make fn call ordering more consistent #

Patch Set 3 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M components/autofill/core/browser/autofill_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 2 8 chunks +20 lines, -13 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
https://codereview.chromium.org/940723002/diff/1/components/autofill/core/browser/autofill_manager.cc File components/autofill/core/browser/autofill_manager.cc (right): https://codereview.chromium.org/940723002/diff/1/components/autofill/core/browser/autofill_manager.cc#newcode1098 components/autofill/core/browser/autofill_manager.cc:1098: personal_data_->RecordUseOf(data_model); as you can see, the meat of the ...
5 years, 10 months ago (2015-02-18 21:05:36 UTC) #2
please use gerrit instead
lgtm, but get this line to compile in debug build: DCHECK_EQ(unmasking_card_ == data_model, !value.empty());
5 years, 10 months ago (2015-02-18 21:22:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940723002/40001
5 years, 10 months ago (2015-02-19 01:07:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 02:36:20 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 02:37:03 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/40304324a852eaedfefb037b300a378c2800d97c
Cr-Commit-Position: refs/heads/master@{#316976}

Powered by Google App Engine
This is Rietveld 408576698