Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 940713003: Enable PIN browser tests on the waterfall. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
anandc, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PIN browser tests on the waterfall. This CL enables PIN browser tests on the waterfall. It introduce in a timeout in ConnectMe2Me to account for the asynchronous click handler hooking of the 'this-host-connect' button. BUG=399839 TEST=Test Passed on Chromoting waterfall. See https://chromium-swarm.appspot.com/user/tasks?sort=created_ts&state=all&limit=10&task_name=chromoting_integration_tests. Committed: https://crrev.com/22f26db751e387ba3c6eb992604a3440720f7d4a Cr-Commit-Position: refs/heads/master@{#317663}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reviewers feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M remoting/webapp/browser_test/browser_test.js View 1 4 chunks +12 lines, -8 lines 1 comment Download
M testing/chromoting/browser_test_commands_linux.txt View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
kelvinp
PTAL
5 years, 10 months ago (2015-02-23 19:58:10 UTC) #2
Jamie
lgtm https://codereview.chromium.org/940713003/diff/1/remoting/webapp/browser_test/browser_test.js File remoting/webapp/browser_test/browser_test.js (right): https://codereview.chromium.org/940713003/diff/1/remoting/webapp/browser_test/browser_test.js#newcode194 remoting/webapp/browser_test/browser_test.js:194: // is hooked asynchronously. It's not entirely clear ...
5 years, 10 months ago (2015-02-23 20:56:26 UTC) #3
kelvinp
FYI https://codereview.chromium.org/940713003/diff/20001/remoting/webapp/browser_test/browser_test.js File remoting/webapp/browser_test/browser_test.js (right): https://codereview.chromium.org/940713003/diff/20001/remoting/webapp/browser_test/browser_test.js#newcode273 remoting/webapp/browser_test/browser_test.js:273: browserTest.onUIMode(AppMode.CLIENT_CONNECT_FAILED_ME2ME), Better handle test flakiness on IT2Me tests. ...
5 years, 10 months ago (2015-02-23 21:17:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940713003/20001
5 years, 10 months ago (2015-02-23 21:19:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 22:15:36 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 22:16:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22f26db751e387ba3c6eb992604a3440720f7d4a
Cr-Commit-Position: refs/heads/master@{#317663}

Powered by Google App Engine
This is Rietveld 408576698