Issue 940703002: Make it possible to load a WebFrame from a URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 940703002: Make it possible to load a WebFrame from a URL (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make it possible to load a WebFrame from a URL Previously, the WebFrame need to be created with a data pipe consumer handle. This CL makes it possible to create a WebFrame with a URL and have the engine issue the network request. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e48f0ef634d2b62e85e227685ab5e52acdac13f9

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -7 lines)			Patch
M	sky/engine/core/loader/MojoLoader.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/engine/core/loader/MojoLoader.cpp	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/engine/public/web/WebFrame.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.h	View		5 chunks	+7 lines, -0 lines	0 comments	Download
M	sky/engine/web/WebLocalFrameImpl.cpp	View	1	1 chunk	+16 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 10 months ago (2015-02-18 20:57:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e48f0ef634d2b62e85e227685ab5e52acdac13f9 (presubmit successful).