chrome/browser/ui/zoom/zoom_controller_browsertest.cc - Issue 940673002: No need to suppress ZoomBubble if !window_->IsActive().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

Issue 940673002: No need to suppress ZoomBubble if !window_->IsActive(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-remove stale comment. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

diff --git a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

index a16336c125e40764868b95e18c7e609680992261..83ad727a8782a45876fd6f5f4f5dca39decae39b 100644

--- a/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

+++ b/chrome/browser/ui/zoom/zoom_controller_browsertest.cc

@@ -138,7 +138,7 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, OnPreferenceChanged) {

new_default_zoom_level,

ZoomController::ZOOM_MODE_DEFAULT,

- true);

+ false);

ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);

// TODO(wjmaclean): Convert this to call partition-specific zoom level prefs

// when they become available.

@@ -232,7 +232,7 @@ IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, Observe) {

new_zoom_level,

ZoomController::ZOOM_MODE_DEFAULT,

- true); // We have a non-empty host, so this will be 'true'.

+ false); // The ZoomController did not initiate, so this will be 'false'.

ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);

content::HostZoomMap* host_zoom_map =

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm ('k') | components/ui/zoom/zoom_controller.cc » ('j') | no next file with comments »