Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/ui/browser.cc

Issue 940673002: No need to suppress ZoomBubble if !window_->IsActive(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-remove stale comment. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 2f7f206b449567917db080f7bae7ea9d88bac48e..53dfccd6dffaa85ee85a49c9146305cb6e6385c5 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1938,9 +1938,7 @@ void Browser::URLStarredChanged(content::WebContents* web_contents,
void Browser::OnZoomChanged(
const ui_zoom::ZoomController::ZoomChangedEventData& data) {
if (data.web_contents == tab_strip_model_->GetActiveWebContents()) {
- // Only show the zoom bubble for zoom changes in the active window.
- window_->ZoomChangedForActiveTab(data.can_show_bubble &&
- window_->IsActive());
+ window_->ZoomChangedForActiveTab(data.can_show_bubble);
// Change the zoom commands state based on the zoom state
command_controller_->ZoomStateChanged();
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698