Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3518)

Unified Diff: chrome/browser/ui/browser.cc

Issue 940673002: No need to suppress ZoomBubble if !window_->IsActive(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-apply fix test expectations. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 2f7f206b449567917db080f7bae7ea9d88bac48e..f591baf06a78f5c5953b0779a7ea71d3fad62c5f 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1939,8 +1939,7 @@ void Browser::OnZoomChanged(
const ui_zoom::ZoomController::ZoomChangedEventData& data) {
if (data.web_contents == tab_strip_model_->GetActiveWebContents()) {
// Only show the zoom bubble for zoom changes in the active window.
rohitrao (ping after 24h) 2015/02/25 18:28:01 Is this comment now incorrect?
wjmaclean 2015/02/25 18:40:12 Ooops, yes ... I'll remove it.
- window_->ZoomChangedForActiveTab(data.can_show_bubble &&
- window_->IsActive());
+ window_->ZoomChangedForActiveTab(data.can_show_bubble);
rohitrao (ping after 24h) 2015/02/25 18:28:01 Is it still correct for this method to have "ForAc
wjmaclean 2015/02/25 18:40:12 I think so, though it is an unfortunate coincidenc
// Change the zoom commands state based on the zoom state
command_controller_->ZoomStateChanged();
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698