Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 940663002: Runtime configuration section of docs (Closed)

Created:
5 years, 10 months ago by hcm
Modified:
5 years, 10 months ago
Reviewers:
humper
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : formatting update #

Patch Set 3 : title update #

Total comments: 1

Patch Set 4 : remove unnecessary backslash escapes #

Patch Set 5 : too much fun with formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -0 lines) Patch
A site/dev/runtime/config.md View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A site/dev/runtime/index.md View 1 2 3 4 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hcm
On 2015/02/18 19:42:21, hcm wrote: > mailto:hcm@google.com changed reviewers: > + mailto:humper@google.com Greg, I transferred ...
5 years, 10 months ago (2015-02-18 19:43:03 UTC) #2
humper
On 2015/02/18 19:43:03, hcm wrote: > On 2015/02/18 19:42:21, hcm wrote: > > mailto:hcm@google.com changed ...
5 years, 10 months ago (2015-02-18 19:57:55 UTC) #3
humper
https://codereview.chromium.org/940663002/diff/40001/site/dev/runtime/index.md File site/dev/runtime/index.md (right): https://codereview.chromium.org/940663002/diff/40001/site/dev/runtime/index.md#newcode149 site/dev/runtime/index.md:149: `skRTConfRegistry\(\)\.possiblyDumpFile\(\); `or simply use `SkAutoGraphics These backslashes are showing ...
5 years, 10 months ago (2015-02-18 20:22:10 UTC) #4
hcm
On 2015/02/18 20:22:10, humper wrote: > https://codereview.chromium.org/940663002/diff/40001/site/dev/runtime/index.md > File site/dev/runtime/index.md (right): > > https://codereview.chromium.org/940663002/diff/40001/site/dev/runtime/index.md#newcode149 > ...
5 years, 10 months ago (2015-02-18 20:47:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940663002/80001
5 years, 10 months ago (2015-02-18 20:47:59 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 20:55:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/606df7ad9835125639a1bfa5b9013d9b3b478c85

Powered by Google App Engine
This is Rietveld 408576698