Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 940643002: chrome: Remove perf_tests target. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Avi (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: Remove perf_tests target. This is a followup to https://chromium.googlesource.com/chromium/src/+/4ee38944c67548f1314f9fc1ef1363797b28bf02 BUG=None TEST=trybots - GYP and GN builds still works. R=thestig@chromium.org Committed: https://crrev.com/3ea233235a9a882a3f2f1f0730b540124aba60db Cr-Commit-Position: refs/heads/master@{#316907}

Patch Set 1 #

Total comments: 3

Patch Set 2 : add url_parse_perftest.cc to performance_browser_tests_sources list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -98 lines) Patch
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -52 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/test/perf/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/perf/perftests.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
tfarina
https://codereview.chromium.org/940643002/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (left): https://codereview.chromium.org/940643002/diff/1/chrome/chrome_tests.gypi#oldcode2896 chrome/chrome_tests.gypi:2896: 'test/perf/url_parse_perftest.cc', I want to deal with url_parse_perftest.cc in a ...
5 years, 10 months ago (2015-02-18 19:17:40 UTC) #1
Lei Zhang
looking good, but... https://codereview.chromium.org/940643002/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (left): https://codereview.chromium.org/940643002/diff/1/chrome/chrome_tests.gypi#oldcode2896 chrome/chrome_tests.gypi:2896: 'test/perf/url_parse_perftest.cc', On 2015/02/18 19:17:40, tfarina wrote: ...
5 years, 10 months ago (2015-02-18 20:25:28 UTC) #2
tfarina
https://codereview.chromium.org/940643002/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (left): https://codereview.chromium.org/940643002/diff/1/chrome/chrome_tests.gypi#oldcode2896 chrome/chrome_tests.gypi:2896: 'test/perf/url_parse_perftest.cc', On 2015/02/18 20:25:28, Lei Zhang (Soon to be ...
5 years, 10 months ago (2015-02-18 20:28:47 UTC) #3
Lei Zhang
On 2015/02/18 20:28:47, tfarina wrote: > Maybe. The problem is that this file does nothing ...
5 years, 10 months ago (2015-02-18 20:37:19 UTC) #4
tfarina
Yup. Thanks for catching that. ptal.
5 years, 10 months ago (2015-02-18 20:46:07 UTC) #5
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-18 22:14:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940643002/20001
5 years, 10 months ago (2015-02-18 22:36:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 22:56:03 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 22:57:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ea233235a9a882a3f2f1f0730b540124aba60db
Cr-Commit-Position: refs/heads/master@{#316907}

Powered by Google App Engine
This is Rietveld 408576698