Added disjoint context class which manages disjoints within gpu timing.

gpu/command_buffer/service/gpu_timing.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_GPU_TIMING_H_
 #define GPU_COMMAND_BUFFER_SERVICE_GPU_TIMING_H_
 
+#include <vector>
+
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "gpu/gpu_export.h"
 
 namespace gfx {
 class GLContext;
 }
 
 namespace gpu {
 class GPUTiming;
@@ skipping 26 matching lines @@
 // to a single GPUTimer.
 class GPU_EXPORT GPUTiming {
  public:
   enum TimerType {
     kTimerTypeInvalid = -1,
 
     kTimerTypeARB,      // ARB_timer_query
     kTimerTypeDisjoint  // EXT_disjoint_timer_query
   };
 
-  GPUTiming();
+  GPUTiming(gfx::GLContext* gl_context = NULL);

[Daniele Castagna, 2015/02/23 22:21:19]

nit: explicit

Why do you pass the context here? Are you passing an actual context to the
constructor anywhere?

nullptr is preferred according to https://chromium-cpp.appspot.com/

   virtual ~GPUTiming();
 
-  bool Initialize(gfx::GLContext* context);
+  void Initialize(gfx::GLContext* gl_context);
   bool IsAvailable();
 
+  int CreateDisjointContextID();
+  bool ReleaseDisjointContextID(int disjoint_context_id);
+  int GetDisjointContextIDCount() const;
+
   // CheckAndResetTimerErrors has to be called before reading timestamps
   // from GPUTimers instances and after making sure all the timers
   // were available.
   // If the returned value is false, all the previous timers should be
   // discarded.
-  bool CheckAndResetTimerErrors();
-
+  bool CheckAndResetTimerErrors(int disjoint_context_id);

[Daniele Castagna, 2015/02/23 22:21:19]

Can you leave the previous method as well, so that this api can be used without
creating a disjoint_context_id.

+  
+  TimerType GetTimerType() const { return timer_type_; }
   const char* GetTimerTypeName() const;
 
   // Returns the offset between the current gpu time and the cpu time.
   int64 CalculateTimerOffset();
   void InvalidateTimerOffset();
 
   void SetCpuTimeForTesting(const base::Callback<int64(void)>& cpu_time);
-  void SetOffsetForTesting(int64 offset, bool cache_it);
-  void SetTimerTypeForTesting(TimerType type);
 
  private:
   TimerType timer_type_ = kTimerTypeInvalid;
   int64 offset_ = 0;  // offset cache when timer_type_ == kTimerTypeARB
   bool offset_valid_ = false;
+  bool disjoint_occurred_ = false;
   base::Callback<int64(void)> cpu_time_for_testing_;
+
+  struct DisjointContext {
+    DisjointContext(bool initial_value)
+        : valid_(true),
+          disjoint_value_(initial_value) {
+    }
+    bool valid_;
+    bool disjoint_value_;
+  };
+  std::vector<DisjointContext> disjoint_contexts_;

[Daniele Castagna, 2015/02/23 22:21:19]

You never shrink this vector when a context is released.

+
   friend class GPUTimer;
   DISALLOW_COPY_AND_ASSIGN(GPUTiming);
 };
 }  // namespace gpu
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GPU_TIMING_H_