Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: build/download_sdk_extras.py

Issue 940633003: Catch AccessDeniedException on bots without permission to download SDK extras. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: If OS=android not in GYP_DEFINES then not Android bot, return 0. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_sdk_extras.py
diff --git a/build/download_sdk_extras.py b/build/download_sdk_extras.py
index 45e71996f1f545f02b0a3c6dda6a5daa3450da8f..56ee18f4880137b361ca8e63e5fb44a525fcd542 100755
--- a/build/download_sdk_extras.py
+++ b/build/download_sdk_extras.py
@@ -9,6 +9,8 @@ The script expects arguments that specify zips file in the google storage
bucket named: <dir in SDK extras>_<package name>_<version>.zip. The file will
be extracted in the android_tools/sdk/extras directory on the test bots. This
script will not do anything for developers.
+
+TODO(navabi): Move this script (crbug.com/459819).
"""
import json
@@ -47,6 +49,9 @@ def main():
if not os.environ.get('CHROME_HEADLESS'):
# This is not a buildbot checkout.
return 0
+ elif 'OS=android' not in os.environ.get('GYP_DEFINES', ''):
+ # Not an Android buildbot.
+ return 0
# Update the android_sdk_extras.json file to update downloaded packages.
with open(SDK_EXTRAS_JSON_FILE) as json_file:
packages = json.load(json_file)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698