Catch AccessDeniedException on bots without permission to download SDK extras.

build/download_sdk_extras.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to download sdk/extras packages on the bots from google storage.
 
 The script expects arguments that specify zips file in the google storage
 bucket named: <dir in SDK extras>_<package name>_<version>.zip. The file will
 be extracted in the android_tools/sdk/extras directory.
@@ skipping 30 matching lines @@
   if not os.path.exists(GSUTIL_PATH) or not os.path.exists(SDK_EXTRAS_PATH):
     # This is not a buildbot checkout.
     return 0
   # Update the android_sdk_extras.json file to update downloaded packages.
   with open(SDK_EXTRAS_JSON_FILE) as json_file:
     packages = json.load(json_file)
   for package in packages:
     local_zip = '%s/%s' % (SDK_EXTRAS_PATH, package['zip'])
     if not os.path.exists(local_zip):
       package_zip = '%s/%s' % (SDK_EXTRAS_BUCKET, package['zip'])
-      subprocess.check_call([GSUTIL_PATH, '--force-version', '4.7', 'cp',
-                            package_zip, local_zip])
+      try:
+        subprocess.check_call(['python', GSUTIL_PATH, '--force-version', '4.7',

[hinoka, 2015/02/18 21:33:07]

s/'python'/sys.executable/

[navabi, 2015/02/18 22:47:03]

I don't think this works on windows. I would expect I would see the same error I
had seen on other patches. I.e. 

WindowsError: [Error 193] %1 is not a valid Win32 application

+                               'cp', package_zip, local_zip])
+      except AccessDeniedException:
+        print ('WARNING: Bot does not have permission to download SDK packages.'
+               ' If this bot compiles for Android, it may have errors.')

[hshi1, 2015/02/18 21:32:27]

why is android_sdk_extras among the packages in the first place? shouldn't we
only download sdk extras for android builds?

[navabi, 2015/02/18 22:47:03]

If possible, we should only call download_sdk_packages.py for android, but I
could not find a way to distinguish platform for hooks (only for deps_os). See
src/DEPS. How do you suggest doing this?

[Sam Clegg, 2015/02/19 01:24:30]

There are other scripts that do this by inspecting GYP_DEFINES (See
download_nacl_toolchains.py).  Its not pretty, but I don't know of any other
way.

Also, I think then name of this script could be more descriptive.  'sdk_extras'
is very generic.  but thats a different CL I guess.

If you are going to handle the exception that you should probably return 0 in
the handler, no?   But its probably better not to handle it but to return early
for non-android bots.

     # Always clean dir and extract zip to ensure correct contents.
     clean_and_extract(package['dir_name'], package['package'], package['zip'])
 
 
 if __name__ == '__main__':
   sys.exit(main())