Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 940613002: Add more targets to "gn check" (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
Dirk Pranke, armansito
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more targets to "gn check" R=dpranke TBR=armansito@chromium.org (bluetooth) Committed: https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac Cr-Commit-Position: refs/heads/master@{#317160}

Patch Set 1 #

Patch Set 2 : android #

Patch Set 3 : chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M .gn View 1 chunk +6 lines, -0 lines 0 comments Download
M dbus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M device/core/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M device/hid/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M device/serial/BUILD.gn View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M device/vibration/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/vibration/android/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
brettw
5 years, 10 months ago (2015-02-19 22:30:29 UTC) #2
Dirk Pranke
lgtm
5 years, 10 months ago (2015-02-19 22:31:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940613002/40001
5 years, 10 months ago (2015-02-19 22:49:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44004)
5 years, 10 months ago (2015-02-19 22:56:42 UTC) #7
brettw
5 years, 10 months ago (2015-02-19 22:58:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940613002/40001
5 years, 10 months ago (2015-02-19 22:59:52 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 23:04:12 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac Cr-Commit-Position: refs/heads/master@{#317160}
5 years, 10 months ago (2015-02-19 23:05:03 UTC) #13
Devlin
5 years, 10 months ago (2015-02-20 01:05:43 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/941893002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: This broken win8 gn bots because of an illegal
include.

ERROR at //device/usb/usb_service_impl.cc:21:11: Include not allowed.
#include "device/core/device_monitor_win.h"

e.g.
https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4896/step....

Powered by Google App Engine
This is Rietveld 408576698